Re: [PATCH v2 3/4] t7450: test submodule urls
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 19, 2024, 18:16 UTC
- Message-ID
- <xmqqbk9hkx3p.fsf@gitster.g>
- In-Reply-To
- <ZaoRDniGoIBXmjVx@tanuki>
Patrick Steinhardt <ps@pks.im> writes:
Show 8 quoted lines
>> Add two tests to separately address cases where the URL check correctly
>> filters out invalid URLs and cases where the check misses invalid URLs. Mark
>> the latter ("url check misses invalid cases") with 'test_expect_failure' to
>> indicate that this not the undesired behavior.
>
> Nit: this should probably say "to indicate that this is not the desired
> behaviour." But given that the other patches in this series look good to
> me I don't think this warrants a reroll.Good eyes.
I'll rewrite that part to "... to indicate that this is currently broken, which will be fixed in the next step." before merging the series to 'next'.
Thanks.