Re: Regression: git send-email fails with "Use of uninitialized value $address" + "unable to extract a valid address"

From: Michael Strawbridge <michael.strawbridge@amd.com>
Date: Oct 26, 2023, 13:07 UTC
Message-ID: <a71f2f1f-b5f0-4628-a4f3-6fd1319062a3@amd.com>
In-Reply-To: <xmqqsf5xr1xk.fsf@gitster.g>

On 10/26/23 08:41, Junio C Hamano wrote:

Show 9 quoted lines

> Jeff King <peff@peff.net> writes:
> 
>> Note that the bug will only trigger if Email::Valid is installed.
> 
> I recall we chased a different bug that depends on the use/non-use
> of this package a few years ago.  Is the difference significant
> enough that we may want to install on one but not in another CI
> environment, like we have a separate CI jobs with exotic settings, I
> wonder.

That would make sense to me. We have had 3 regressions threads recently for git send email where Email::Valid was important.

- [REGRESSION] uninitialized value $address in git send-email when given multiple recipients separated by commas - (this thread)
- [REGRESSION] uninitialized value $address in git send-email - https://public-inbox.org/git/20230918212004.GC2163162@coredump.intra.peff.net/T/#m9e0211a8ad387adbbadf31dcfcd7982d4046633d
- Regression: git send-email fails with "Use of uninitialized value $address" + "unable to extract a valid address" - https://public-inbox.org/git/68d7e5c3-6b4a-4d0d-9885-f3d4e2199f26@amd.com/T/#m1411c155e11ad9c5d913d22d1d11180ed56eabc7