git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Regression: git send-email fails with "Use of uninitialized value $address" + "unable to extract a valid address"

From
Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date
Oct 24, 2023, 13:00 UTC
Message-ID
<20231024130037.sbevzk2x7oclj7d7@pengutronix.de>
In-Reply-To
<68d7e5c3-6b4a-4d0d-9885-f3d4e2199f26@amd.com>
Hello,
On Fri, Oct 20, 2023 at 05:06:36PM -0400, Michael Strawbridge wrote:
Show 29 quoted lines
> On 10/20/23 06:04, Uwe Kleine-König wrote:
> > hello,
> > 
> > On Fri, Oct 13, 2023 at 04:14:37PM +0200, Uwe Kleine-König wrote:
> >> Hello,
> >>
> >> 	$ git send-email --to 'A B <a@b.org>, C D <c@d.org>' lala.patch
> >> 	Use of uninitialized value $address in sprintf at /usr/lib/git-core/git-send-email line 1172.
> >> 	error: unable to extract a valid address from:
> >>
> >> This happens for me with git 2.42.0 and also on master (59167d7d09fd, "The seventeenth batch").
> >>
> >> Bisection points at
> >>
> >> 	a8022c5f7b67 ("send-email: expose header information to git-send-email's sendemail-validate hook")
> >>
> >> I didn't try to understand that change and fix the problem.
> > 
> > Another (similar?) problem with non-ascii-chars:
> > 
> > 	$ git send-email --to 'Will Deacon <will@kernel.org>' --to 'Krzysztof Wilczyński <kw@linux.com>' --to 'Lorenzo Pieralisi <lpieralisi@kernel.org>' --cc 'Rob Herring <robh@kernel.org>' --to 'Bjorn Helgaas <bhelgaas@google.com>' --cc 'linux-pci@vger.kernel.org' --cc kernel@pengutronix.de -1 --base=@~
> > 	Use of uninitialized value $address in sprintf at /home/uwe/gsrc/git/git-send-email line 1162.
> > 	error: unable to extract a valid address from:
> > 
> > Bisection points to the same commit, when dropping ń in Krzysztof's
> > name, it works fine.
> > 
> This is interesting.  Thanks for reporting it.  If you are able, could you please try the patches found in the below threads:
> - https://public-inbox.org/git/20230918212004.GC2163162@coredump.intra.peff.net/T/#mae64003cbb72f015bf5c0c04216524fcb6bb8d09

On main (2e8e77cbac8a) this one is already applied, with that the error message reduces to:

	$ git send-email --to 'Uwe Kleine-König <u.kleine-koenig@pengutronix.de>' -1
	error: unable to extract a valid address from: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> - https://public-inbox.org/git/f5c6a72b-f888-4d43-8be8-3ce2c878c669@gmail.com/T/#mca12dc95ccfd3ce2b94e7752ebaae9891201084f

This one doesn't help either. With it applied on top of main I get the sams result as on vanilla main.

Best regards Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
Previous: Michael StrawbridgeNext: Michael Strawbridge
Message 5 of 14 in “Regression: git send-email fails with "Use of uninitialized value $address" + "unable to extract a valid address"”
  1. Uwe Kleine-KönigOct 13, 2023
  2. Kristoffer HaugsbakkOct 13, 2023
  3. Uwe Kleine-KönigOct 20, 2023
  4. Michael StrawbridgeOct 20, 2023
  5. Uwe Kleine-KönigOct 24, 2023
  6. Michael StrawbridgeOct 24, 2023
  7. Uwe Kleine-KönigOct 24, 2023
  8. Jeff KingOct 25, 2023
  9. Uwe Kleine-KönigOct 25, 2023
  10. Junio C HamanoOct 26, 2023
  11. Michael StrawbridgeOct 26, 2023
  12. Todd ZullingerOct 26, 2023
  13. Junio C HamanoOct 27, 2023
  14. Jeff KingOct 30, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.