Re: Regression: git send-email fails with "Use of uninitialized value $address" + "unable to extract a valid address"

From: Jeff King <peff@peff.net>
Date: Oct 30, 2023, 09:29 UTC
Message-ID: <20231030092903.GD84866@coredump.intra.peff.net>
In-Reply-To: <ZTp7xvXDw1GF-NUB@pobox.com>

On Thu, Oct 26, 2023 at 10:46:30AM -0400, Todd Zullinger wrote:

Show 5 quoted lines

> I'd lean toward dropping the dependency entirely and leave
> the more basic validation of git-send-email in place.  That
> may not catch every type of address error, but I would argue
> that what we do without Email::Valid is perfectly reasonable
> for checking basic email address syntax sanity.

I am somewhat tempted to say the same, but in this case didn't it help us find a real bug? True, the bug was that we were feeding garbage to Email::Valid because we were calling it to early, and I _think_ the ultimate emails we sent would have been OK. But I think we were possibly feeding that garbage to the user-visible validation hook.

That might just mean we need to beef up our homegrown validation a bit (though as you indicate here, I am generally of the opinion that the best validation is trying to actually send things).

-Peff