Re: Regression: git send-email fails with "Use of uninitialized value $address" + "unable to extract a valid address"
- From
Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
- Date
- Oct 24, 2023, 20:43 UTC
- Message-ID
- <20231024204318.gi6b4ygqbilm2yke@pengutronix.de>
- In-Reply-To
- <89712aea-04fc-4775-afd4-afd3ca24ad01@amd.com>
Hello Michael,
On Tue, Oct 24, 2023 at 03:00:38PM -0400, Michael Strawbridge wrote:
Show 13 quoted lines
> On 10/24/23 09:00, Uwe Kleine-König wrote: > > On Fri, Oct 20, 2023 at 05:06:36PM -0400, Michael Strawbridge wrote: > >> On 10/20/23 06:04, Uwe Kleine-König wrote: > >>> On Fri, Oct 13, 2023 at 04:14:37PM +0200, Uwe Kleine-König wrote: > >>>> $ git send-email --to 'A B <a@b.org>, C D <c@d.org>' lala.patch > >>>> Use of uninitialized value $address in sprintf at /usr/lib/git-core/git-send-email line 1172. > >>>> error: unable to extract a valid address from: > >>>> > >>>> This happens for me with git 2.42.0 and also on master (59167d7d09fd, "The seventeenth batch"). > Hm. I tried reproing with master (59167d7d09fd, "The seventeenth batch") but I don't seem to see an error: > ``` > $ git send-email --to 'Uwe Kleine-König <u.kleine-koenig@pengutronix.de>' -1 --smtp-server="$(pwd)/fake.sendmail" > [...]
I debugged a bit and if I do
mv .git/hooks/sendemail-validate .git/hooks/sendemail-validate.bak
git send-email --to 'Uwe Kleine-König <u.kleine-koenig@pengutronix.de>' starts to work for me, too.
I'd guess the content of my sendemail-validate script doesn't matter much, but for the record, it's:
#!/bin/sh
# installed by patatt install-hook
patatt sign --hook "${1}"Does the problem reproduce on your end with a sendemail-validate script?
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |