Re: [PATCH 1/2] replay: die descriptively when invalid commit-ish

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Dec 23, 2025, 10:52 UTC
Message-ID: <a5822145-5a5c-4a2b-84b9-7c061b3bab97@gmail.com>
In-Reply-To: <xmqqikdxriw3.fsf@gitster.g>

On 23/12/2025 03:12, Junio C Hamano wrote:

Show 8 quoted lines

> kristofferhaugsbakk@fastmail.com writes:
> 
> How many callers use this function?  I am wondering if it is better
> to give a better message at the caller(s), rather than here, where
> we lack context to tell something like "You gave string 'ource' as
> the argument to the '--onto' option, but 'ource' does not name any
> commit" (in other words, "for what our caller is trying to peel
> <name> to a commit").

There are only two callers so I think that is a good idea. If you give an invalid commit name to "--advance" then it dies with

     fatal: argument to --advance must be a reference

so arguably we only need to check the return value when parsing "--onto"

Thanks

Phillip