Re: [PATCH v2 0/5] replay: die descriptively when invalid commit-ish

From: Elijah Newren <newren@gmail.com>
Date: Dec 30, 2025, 22:53 UTC
Message-ID: <CABPp-BFgYzZX8jza_Ch0_KOC61iuM_WBikzXyLJuWF69yHqgNw@mail.gmail.com>
In-Reply-To: <V2_CV_replay_die_descr.17b@msgid.xyz>

On Tue, Dec 30, 2025 at 7:02 AM <kristofferhaugsbakk@fastmail.com> wrote:

[...]

Show 10 quoted lines

> § Changes in v2
>
> In this version we remove some dead code (see previous section), improve
> tests and add a couple more, and improve the main “die descriptively”
> part, with two additional patches/commits to that end:
>
> • replay: find *onto only after testing for ref name
> • replay: die if we cannot parse object
>
> See the notes on each patch/commit for change details.

I had a few minor comments on a few of the patches, but otherwise it looked good to me.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.