git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv2 0/3] Make diff plumbing commands respect the indentHeuristic.

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Apr 30, 2017, 03:26 UTC
Message-ID
<a0d14b53-01c2-c653-15c9-ff566d24a782@alum.mit.edu>
In-Reply-To
<20170429124052.yhgwofbbd5pkd24p@sigill.intra.peff.net>
On 04/29/2017 02:40 PM, Jeff King wrote:
Show 16 quoted lines
> On Fri, Apr 28, 2017 at 06:33:12PM -0400, Marc Branchaud wrote:
> 
>> v2: Fixed up the commit messages and added tests.
>>
>> Marc Branchaud (2):
>>   diff: make the indent heuristic part of diff's basic configuration
>>   diff: have the diff-* builtins configure diff before initializing
>>     revisions
>>
>> Stefan Beller (1):
>>   diff: enable indent heuristic by default
> 
> Thanks, these look fine to me. I'd like to get an ACK from Michael, in
> case he had some other reason for omitting them from git_diff_ui_config
> (from my recollection, it's probably just a mix of conservatism and
> following what the compaction heuristic had done).

That's exactly right. The only discussion I remember about broadening the scope of diff options was with regards to `blame` [1]. I don't really have enough overview of these configuration topics to have much an opinion.

Michael

[1] http://public-inbox.org/git/xmqqtwebwhbg.fsf@gitster.mtv.corp.google.com/

Previous: Jeff King
Message 35 of 35 in “Make diff plumbing commands respect the indentHeuristic.”
  1. 0/2 Make diff plumbing commands respect the indentHeuristic.Marc Branchaud, Apr 27, 2017
  2. 2/2 Have the diff-* builtins configure diff before initializing revisions.Marc Branchaud, Apr 27, 2017
  3. Jeff KingApr 28, 2017
  4. Junio C HamanoMay 1, 2017
  5. Jeff KingMay 1, 2017
  6. Jeff KingMay 1, 2017
  7. 1/2 Make the indent heuristic part of diff's basic configuration.Marc Branchaud, Apr 27, 2017
  8. Jeff KingApr 28, 2017
  9. Jeff KingApr 28, 2017
  10. Stefan BellerApr 28, 2017
  11. Jeff KingApr 28, 2017
  12. Stefan BellerApr 28, 2017
  13. Ævar Arnfjörð BjarmasonMay 1, 2017
  14. Jeff KingMay 9, 2017
  15. Junio C HamanoMay 9, 2017
  16. Ævar Arnfjörð BjarmasonMay 9, 2017
  17. Jeff KingMay 9, 2017
  18. 0/3 Make diff plumbing commands respect the indentHeuristic.Marc Branchaud, Apr 28, 2017
  19. 1/3 diff: make the indent heuristic part of diff's basic configurationMarc Branchaud, Apr 28, 2017
  20. 2/3 diff: have the diff-* builtins configure diff before initializing revisionsMarc Branchaud, Apr 28, 2017
  21. 3/3 diff: enable indent heuristic by defaultMarc Branchaud, Apr 28, 2017
  22. Jeff KingApr 29, 2017
  23. Jeff KingApr 29, 2017
  24. Junio C HamanoMay 1, 2017
  25. Jeff KingMay 1, 2017
  26. Junio C HamanoMay 1, 2017
  27. 0/4 Make diff plumbing commands respect the indentHeuristic.Marc Branchaud, May 1, 2017
  28. 2/4 diff: have the diff-* builtins configure diff before initializing revisionsMarc Branchaud, May 1, 2017
  29. 1/4 diff: make the indent heuristic part of diff's basic configurationMarc Branchaud, May 1, 2017
  30. 4/4 add--interactive: drop diff.indentHeuristic handlingMarc Branchaud, May 1, 2017
  31. 3/4 diff: enable indent heuristic by defaultMarc Branchaud, May 1, 2017
  32. Jeff KingMay 1, 2017
  33. Stefan BellerMay 1, 2017
  34. 4/3 add--interactive: drop diff.indentHeuristic handlingJeff King, Apr 29, 2017
  35. Michael HaggertyApr 30, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.