Re: [PATCH 0/2] Make diff plumbing commands respect the indentHeuristic.

From: Jeff King <peff@peff.net>
Date: May 9, 2017, 08:04 UTC
Message-ID: <20170509080434.dkqa7pvsq34sygn3@sigill.intra.peff.net>
In-Reply-To: <CACBZZX5yHRDU6R3F8=qnqEGu6UCYNOj3rqMDbP1G7cJnvG7R=g@mail.gmail.com>

On Tue, May 09, 2017 at 09:58:28AM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 8 quoted lines

> > Out of curiosity, how do you generate the patch-ids? Is it with
> > something like diff-tree piped to patch-id?
> 
> This:
> 
>     my $cmd = qq[git --git-dir="$repository_path" log --since="$since"
> --until="$until" --all --pretty=format:%H --binary | git patch-id];
>     open my $patch_id_fh, " $cmd |";

Ah, OK. I was specifically curious whether the decision to respect the config switch in plumbing would have any impact for your script. But it wouldn't, as it was already using log (though I suspect the real protection for your script is that it is used from a vanilla environment, not by random users).

-Peff