Re: [PATCH 1/2] Make the indent heuristic part of diff's basic configuration.

From: Jeff King <peff@peff.net>
Date: Apr 28, 2017, 07:59 UTC
Message-ID: <20170428075932.vnngf3pbl4oh2fta@sigill.intra.peff.net>
In-Reply-To: <20170427205037.1787-2-marcnarc@xiplink.com>

On Thu, Apr 27, 2017 at 04:50:36PM -0400, Marc Branchaud wrote:

> Subject: [PATCH 1/2] Make the indent heuristic part of diff's basic configuration.
>
> Signed-off-by: Marc Branchaud <marcnarc@xiplink.com>

This needs to be explained better. Why were the options originally in UI config, and why is it OK to move them to the basic config?

I think the argument is along the lines of "scripts shouldn't care because the result is syntactically identical, and we reserve the right to find any valid diff".

Also, our subject lines usually do not start with a capital, nor end with a period. We usually try to specify the subsystem with a colon. Like:

  diff: move indent heuristic to "basic" config

or similar.

-Peff