Re: [PATCH v2 00/21] environment: guard reliance on `the_repository`
On Thu, Sep 12, 2024 at 04:14:53AM -0700, karthik nayak wrote:
Show 23 quoted lines
> Patrick Steinhardt <ps@pks.im> writes:
>
> > Hi,
> >
> > this is the second version of my patch series which guards functions and
> > variables in the environment subsystem that rely on `the_repository`
> > with the `USE_THE_REPOSITORY_VARIABLE` define.
> >
> > Changes compared to v1:
> >
> > - Clean up now-unnecessary and add newly-necessary includes.
> >
> > - Stop reordering includes in "setup.c".
> >
> > - Fix missing `USE_THE_REPOSITORY_VARIABLE` defines in Win32 code.
> >
> > Thanks!
> >
>
> I haven't read v1, but this version reads nicely. I left two comments,
> and I think the first one applies to the first few patches.
>
> Thanks
Thanks for your review!
Patrick