Re: [PATCH v2 00/21] environment: guard reliance on `the_repository`

From: karthik nayak <karthik.188@gmail.com>
Date: Sep 12, 2024, 11:14 UTC
Message-ID: <CAOLa=ZQ20ndA6cG8_9OHO-Ci5AHu5i2K6O+2hJ8oa6+nhxaPZA@mail.gmail.com>
In-Reply-To: <cover.1725008897.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 16 quoted lines

> Hi,
>
> this is the second version of my patch series which guards functions and
> variables in the environment subsystem that rely on `the_repository`
> with the `USE_THE_REPOSITORY_VARIABLE` define.
>
> Changes compared to v1:
>
>   - Clean up now-unnecessary and add newly-necessary includes.
>
>   - Stop reordering includes in "setup.c".
>
>   - Fix missing `USE_THE_REPOSITORY_VARIABLE` defines in Win32 code.
>
> Thanks!
>

I haven't read v1, but this version reads nicely. I left two comments, and I think the first one applies to the first few patches.

Thanks

[snip]

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.