Re: [PATCH v2 00/21] environment: guard reliance on `the_repository`

From: Patrick Steinhardt <ps@pks.im>
Date: Sep 4, 2024, 07:14 UTC
Message-ID: <ZtgIzZlyOkgtXjnC@pks.im>
In-Reply-To: <D3X4X0B5P0WG.1WHNSQNIRDHYW@jamesliu.io>

On Wed, Sep 04, 2024 at 12:12:54PM +1000, James Liu wrote:

Show 24 quoted lines

> On Fri Aug 30, 2024 at 7:08 PM AEST, Patrick Steinhardt wrote:
> > Hi,
> >
> > this is the second version of my patch series which guards functions and
> > variables in the environment subsystem that rely on `the_repository`
> > with the `USE_THE_REPOSITORY_VARIABLE` define.
> >
> > Changes compared to v1:
> >
> >   - Clean up now-unnecessary and add newly-necessary includes.
> >
> >   - Stop reordering includes in "setup.c".
> >
> >   - Fix missing `USE_THE_REPOSITORY_VARIABLE` defines in Win32 code.
> >
> > Thanks!
> >
> > Patrick
> 
> Thanks Patrick, this is a nice series of cleanups! I've left a few
> comments.
> 
> Apologies that I haven't been able to review these changes until now --
> I've had to take some time off in the past week.

No worries, thanks for your review!

Patrick