Re: [PATCH v2 00/21] environment: guard reliance on `the_repository`

From: James Liu <james@jamesliu.io>
Date: Sep 4, 2024, 02:12 UTC
Message-ID: <D3X4X0B5P0WG.1WHNSQNIRDHYW@jamesliu.io>
In-Reply-To: <cover.1725008897.git.ps@pks.im>

On Fri Aug 30, 2024 at 7:08 PM AEST, Patrick Steinhardt wrote:

Show 17 quoted lines

> Hi,
>
> this is the second version of my patch series which guards functions and
> variables in the environment subsystem that rely on `the_repository`
> with the `USE_THE_REPOSITORY_VARIABLE` define.
>
> Changes compared to v1:
>
>   - Clean up now-unnecessary and add newly-necessary includes.
>
>   - Stop reordering includes in "setup.c".
>
>   - Fix missing `USE_THE_REPOSITORY_VARIABLE` defines in Win32 code.
>
> Thanks!
>
> Patrick

Thanks Patrick, this is a nice series of cleanups! I've left a few comments.

Apologies that I haven't been able to review these changes until now -- I've had to take some time off in the past week.

Cheers, James