Re: [PATCH v3 5/6] [Newcomer] t7004-tag: here-doc modernization

From: Patrick Steinhardt <ps@pks.im>
Date: Aug 5, 2024, 09:42 UTC
Message-ID: <ZrCeaU4VKxPYTPiJ@tanuki>
In-Reply-To: <20240804071137.30326-6-abdobngad@gmail.com>

On Sun, Aug 04, 2024 at 10:11:36AM +0300, AbdAlRahman Gad wrote:

> use <<-\EOF to indent here-doc

Instead of what? It would help to mention that the change converts from <<\EOF to <<\-EOF, where the latter allows us to indent the body.

I'd also suggest a commit title like "t7004: use indented here docs", as "here doc modernizations" doesn't quite give you a hint what the modernization looks like.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.