Re: [PATCH v3 2/6] [Newcomer] t7004-tag: do not lose exit status to pipe

From: Patrick Steinhardt <ps@pks.im>
Date: Aug 5, 2024, 09:36 UTC
Message-ID: <ZrCdK_DbYyxT2D5e@tanuki>
In-Reply-To: <20240804071137.30326-3-abdobngad@gmail.com>

On Sun, Aug 04, 2024 at 10:11:33AM +0300, AbdAlRahman Gad wrote:

> split "test-tool ... | sed" pipeline into two commands
> to avoid losing exit status from test-tool

The commit body should be a full sentence and thus should start with an upper-case letter and end with punctuation.

I'd also drop the "-tag" from "t7004-tag" in the commit subject, as we typically only mention the tag number.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.