git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 1/6] [Newcomer] t7004-tag: redirection operator

From
Patrick Steinhardt <ps@pks.im>
Date
Aug 5, 2024, 09:36 UTC
Message-ID
<ZrCdDHqKfwWbr_Zn@tanuki>
In-Reply-To
<20240804071137.30326-2-abdobngad@gmail.com>
On Sun, Aug 04, 2024 at 10:11:32AM +0300, AbdAlRahman Gad wrote:
> Modernaize 't7004-tag.sh' by removing whitespace
s/Modernaize/Modernize. 
> after the redirect operators.

Also, please note that we typically wrap commit messages after 72 characters.

It would also be helpful to make the commit subject a bit more informative. Right now you only say "redirection operation", which doesn't really give the reader much of a clue what the commit does to those. Better would be something like

    t7004: remove space after redirect operator
This gives the reader a much better signal of what the patch does.
Patrick
Previous: AbdAlRahman GadNext: AbdAlRahman Gad
Message 3 of 15 in “[Newcomer] t7004: modernize the style”
  1. 0/6 [Newcomer] t7004: modernize the styleAbdAlRahman Gad, Aug 4, 2024
  2. 1/6 [Newcomer] t7004-tag: redirection operatorAbdAlRahman Gad, Aug 4, 2024
  3. Patrick SteinhardtAug 5, 2024
  4. 2/6 [Newcomer] t7004-tag: do not lose exit status to pipeAbdAlRahman Gad, Aug 4, 2024
  5. Patrick SteinhardtAug 5, 2024
  6. 3/6 [Newcomer] t7004-tag: one command per lineAbdAlRahman Gad, Aug 4, 2024
  7. Patrick SteinhardtAug 5, 2024
  8. 4/6 [Newcomer] t7004-tag: do not prepare except outside test_expect_successAbdAlRahman Gad, Aug 4, 2024
  9. Eric SunshineAug 4, 2024
  10. AbdAlRahman GadAug 4, 2024
  11. Junio C HamanoAug 4, 2024
  12. 5/6 [Newcomer] t7004-tag: here-doc modernizationAbdAlRahman Gad, Aug 4, 2024
  13. Patrick SteinhardtAug 5, 2024
  14. 6/6 [Newcomer] t7004-tag: description on the same line as test_expect_successAbdAlRahman Gad, Aug 4, 2024
  15. Patrick SteinhardtAug 5, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.