git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 5/6] [Newcomer] t7004-tag: here-doc modernization

From
AbdAlRahman Gad <abdobngad@gmail.com>
Date
Aug 4, 2024, 07:11 UTC
Message-ID
<20240804071137.30326-6-abdobngad@gmail.com>
In-Reply-To
<20240804071137.30326-1-abdobngad@gmail.com>
use <<-\EOF to indent here-doc
Signed-off-by: AbdAlRahman Gad <abdobngad@gmail.com>
---
 t/t7004-tag.sh | 38 +++++++++++++++++++-------------------
 1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/t/t7004-tag.sh b/t/t7004-tag.sh
index 96aa908eaf..c60167d6fd 100755
--- a/t/t7004-tag.sh
+++ b/t/t7004-tag.sh
@@ -389,10 +389,10 @@ test_expect_success 'tag -l <pattern> -l <pattern> works, as our buggy documenta
 
 test_expect_success 'listing tags in column' '
 	COLUMNS=41 git tag -l --column=row >actual &&
-	cat >expected <<\EOF &&
-a1      aa1     cba     t210    t211
-v0.2.1  v1.0    v1.0.1  v1.1.3
-EOF
+	cat >expected <<-\EOF &&
+	a1      aa1     cba     t210    t211
+	v0.2.1  v1.0    v1.0.1  v1.1.3
+	EOF
 	test_cmp expected actual
 '
 
@@ -400,10 +400,10 @@ test_expect_success 'listing tags in column with column.*' '
 	test_config column.tag row &&
 	test_config column.ui dense &&
 	COLUMNS=40 git tag -l >actual &&
-	cat >expected <<\EOF &&
-a1      aa1   cba     t210    t211
-v0.2.1  v1.0  v1.0.1  v1.1.3
-EOF
+	cat >expected <<-\EOF &&
+	a1      aa1   cba     t210    t211
+	v0.2.1  v1.0  v1.0.1  v1.1.3
+	EOF
 	test_cmp expected actual
 '
 
@@ -414,17 +414,17 @@ test_expect_success 'listing tag with -n --column should fail' '
 test_expect_success 'listing tags -n in column with column.ui ignored' '
 	test_config column.ui "row dense" &&
 	COLUMNS=40 git tag -l -n >actual &&
-	cat >expected <<\EOF &&
-a1              Foo
-aa1             Foo
-cba             Foo
-t210            Foo
-t211            Foo
-v0.2.1          Foo
-v1.0            Foo
-v1.0.1          Foo
-v1.1.3          Foo
-EOF
+	cat >expected <<-\EOF &&
+	a1              Foo
+	aa1             Foo
+	cba             Foo
+	t210            Foo
+	t211            Foo
+	v0.2.1          Foo
+	v1.0            Foo
+	v1.0.1          Foo
+	v1.1.3          Foo
+	EOF
 	test_cmp expected actual
 '
 
-- 
2.43.0
Previous: Junio C HamanoNext: Patrick Steinhardt
Message 12 of 15 in “[Newcomer] t7004: modernize the style”
  1. 0/6 [Newcomer] t7004: modernize the styleAbdAlRahman Gad, Aug 4, 2024
  2. 1/6 [Newcomer] t7004-tag: redirection operatorAbdAlRahman Gad, Aug 4, 2024
  3. Patrick SteinhardtAug 5, 2024
  4. 2/6 [Newcomer] t7004-tag: do not lose exit status to pipeAbdAlRahman Gad, Aug 4, 2024
  5. Patrick SteinhardtAug 5, 2024
  6. 3/6 [Newcomer] t7004-tag: one command per lineAbdAlRahman Gad, Aug 4, 2024
  7. Patrick SteinhardtAug 5, 2024
  8. 4/6 [Newcomer] t7004-tag: do not prepare except outside test_expect_successAbdAlRahman Gad, Aug 4, 2024
  9. Eric SunshineAug 4, 2024
  10. AbdAlRahman GadAug 4, 2024
  11. Junio C HamanoAug 4, 2024
  12. 5/6 [Newcomer] t7004-tag: here-doc modernizationAbdAlRahman Gad, Aug 4, 2024
  13. Patrick SteinhardtAug 5, 2024
  14. 6/6 [Newcomer] t7004-tag: description on the same line as test_expect_successAbdAlRahman Gad, Aug 4, 2024
  15. Patrick SteinhardtAug 5, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.