git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] docs: document upcoming breaking changes

From
Patrick Steinhardt <ps@pks.im>
Date
May 30, 2024, 12:04 UTC
Message-ID
<ZlhrY6y829bcHVoZ@tanuki>
In-Reply-To
<xmqqsey7ktn2.fsf@gitster.g>
On Fri, May 24, 2024 at 10:27:13AM -0700, Junio C Hamano wrote:
Show 9 quoted lines
> Patrick Steinhardt <ps@pks.im> writes:
> 
> > case, most of the proposed deprecations didn't get much pushback. I'm
> > less sure whether this is because people didn't look, or because they
> > silently agree with what I propose for deprecation.
> 
> Or because I explicitly said that first we'll brainstorm, in order
> to encourage generation of more ideas, without shooting other
> people's ideas down?
Fair, I guess.
[snip]
Show 9 quoted lines
> > +## Git 3.0
> 
> Question.  
> 
> Will we have "## Git 4.0" etc., to indicate the timelines (some
> stuff we might eventually replace/change, but we may not ready yet
> by the time 3.0 comes)?  Or do we assme that an idea we agree enough
> on to add to this document would all be ready to be implemented by
> 3.0?

Good question. For now I have added such items to the "Superseded features that will not be deprecated" section, with a hint that we may revisit the deprecation in the future. E.g. for the git-config(1) actions I say the following:

    The action flags will not be removed in the next major Git release
    as there likely exist a lot of scripts out there that use the old
    syntax.

I think that this is easiest to manage for other features where we are not yet ready to commit to a deprecation, as well, due to whatever reason. Those items can be added along with a condition that, once met, may prompt us to revisit a deprecation.

Show 28 quoted lines
> > +### Changes
> > +
> > +  - The default initial branch name will be changed from "master" to "main".
> > +
> > +    Cf. <pull.762.git.1605221038.gitgitgadget@gmail.com>,
> > +    <CAMP44s3BJ3dGsLJ-6yA-Po459=+m826KD9an4+P3qOY1vkbxZg@mail.gmail.com>.
> 
> Forcing readers to read entire threads for these two discussions
> somehow feels brutal at least to me.  And reading only these two
> individual messages does not give readers much insight.
> 
> Saying "this was discussed in the past in late 2020, and because
> major hosting sites give 'main' as the initial branch by default for
> new users unless configured these days, we will match to avoid end
> user confusion", if we want to explain why we are changing it,
> should be sufficient.  But seeing that the other two items below do
> not have any such explanation, we may be better of not having it
> here, perhaps?
> 
> I take this iteration to illustrate the format of items (and what
> kinds of items) we want to have in the document.  If the proposal
> made by the above item is:
> 
>     Once we have a discussion thread that shows clear concensus
>     (neither of the above two are not), we'd record the decision and
>     have a reference to the thread.
> 
> then I 100% agree with the plan for this document.

Yes, that's my intent. The bullet item should be self-explaining, potentially with one or two sentences explaining why. The reference to the mailing list thread is supposed to give a pointer where, when and why this decision was made so that people can revisit the discussion.

So the two bullet points below are certainly quite lazy because they do not provide any context whatsoever.

Show 35 quoted lines
> > +  - The default hash function for new repositories will be changed from "sha1"
> > +    to "sha256".
> > +
> > +  - The default ref backend for new repositories will be changed from "files" to
> > +    "reftable".
> > +
> > +### Removals
> > +
> > + - git-http-push(1) can be used to push objects to a remote repository via
> > +   HTTP/DAV. Support for write support via WebDAV is not in widespread use
> > +   nowadays anymore and will be removed together with the command.
> > +
> > + - The dumb HTTP protocol can be used to serve repositories via a plain HTTP
> > +   server like Apache. The protocol has not seen any updates recently and is
> > +   neither compatible with alternative hash functions nor with alternative ref
> > +   backends. It will thus be removed.
> > +
> > + - git-update-server-info(1) generates data required when serving data via the
> > +   dumb HTTP protocol. Given the removal of that protocol, it serves no purpose
> > +   anymore and will be removed together with the protocol. This includes the
> > +   "receive.updateServerInfo" and "repack.updateServerInfo" config keys and the
> > +   `git repack -n` flag.
> > +
> > + - `$GIT_DIR/branches/` and `$GIT_DIR/remotes/` can be used to specify
> > +   shorthands for URLs for git-fetch(1), git-pull(1) and git-push(1). This
> > +   concept has long been replaced by remotes and will thus be removed.
> 
> "remotes" -> "the 'remotes.*.*' configuration variables", perhaps?
> 
> > + - "gitweb" and git-instaweb(1) can be used to browse Git repositories via an
> > +   HTTP server. These scripts have been unmaintained for a significant amount of
> > +   time and will be removed.
> 
> Do we want to give plausible alternatives (or merely hinting
> existence of alternatives might be sufficient)?

I guess that would be solutions like cgit, right? While those recommendations may go stale over time, I still think it'd be worthwhile to help our users in case they do rely on any deprecated feature.

Show 12 quoted lines
> > + - git-filter-branch(1) can be used to rewrite history of a repository. It is
> > +   very slow, hard to use and has many gotchas. It will thus be removed in favor
> > +   of [git-filter-repo](https://github.com/newren/git-filter-repo).
> > +
> > + - The "dashed form", i.e. support for calling `git-<command>` instead of
> > +   `git <command>` in scripts, has been deprecated for a long time and will be
> > +   removed.
> 
> I find this questionable but as you said, we'll start from skeletal
> form of this document (without any items), have discussion thread on
> each of these items, and add back those we have concensus on, so
> I'll not further talk about this item in this message.

I'd propose to have one (hopefully uncontroversial) item per section just to demonstrate how the format is supposed to look like. But other than that I'm happy to drop most of these items.

Show 19 quoted lines
> > + - The command to import patches from Quilt seems to be used rarely, if
> > +   ever, and will be removed.
> 
> Not limited to this item, but do we want to mention in this document
> how we measured the actual usage, which we base our deprecation
> decision on?  I do not think such a comment should be attached to
> each of these items (this one and the next one are proposed for the
> same reason),...
> 
> > + - Support for importing repositories from GNU Arch will be removed because
> > +   it would not appear to have any users.
> 
> ... but in a preamble of the document, e.g., "methodology and
> criteria we used to propose these removals".  Random ideas that may
> or may not work:
> 
>  - debian popcon?
>  - google trends, counting the appearance of queries?
>  - telemetry from commands that call home (we do not have any)?
That would certainly be helpful to give us a better base to argue.
Show 27 quoted lines
> > + - git-config(1) has learned to use subcommands that replace implicit actions
> > +   (e.g. `git config foo.bar baz`) as well as the action flags (e.g. `git config
> > +   --unset-all`). The action flags will not be removed in the next major Git
> > +   release as there likely exist a lot of scripts out there that use the old
> > +   syntax.
> > +
> > +   Cf. <ZjiL7vu5kCVwpsLd@tanuki>.
> 
> This is a good example of "we had a concensus back when this was
> discussed; see the thread this message is on".  I think it would be
> beneficial to write down what these references _mean_ at the beginning
> of the document, e.g.
> 
>     When this document refers to a message-ID, you can visit
> 
>       https://lore.kernel.org/git/$message_id/
> 
>     to see the message and its surrounding discussion.  Such a
>     reference is there to make it easier for you to find that the
>     project reached concensus on the described item back then.  As
>     this is a living document, and the environment surrounding the
>     project changes over time, an earlier decision to deprecate or
>     change something may need to be revisited from time to time, so
>     do not take these references to mean "it is settled, do not
>     waste our time bringing it up again".
> 
> or something like that.
Good idea, will do.
Patrick
Previous: Junio C HamanoNext: Patrick Steinhardt
Message 22 of 70 in “docs: document upcoming breaking changes”
  1. docs: document upcoming breaking changesPatrick Steinhardt, May 7, 2024
  2. Johannes SchindelinMay 7, 2024
  3. Patrick SteinhardtMay 8, 2024
  4. Junio C HamanoMay 7, 2024
  5. Patrick SteinhardtMay 8, 2024
  6. Junio C HamanoMay 8, 2024
  7. Dragan SimicMay 8, 2024
  8. Patrick SteinhardtMay 10, 2024
  9. Dragan SimicMay 10, 2024
  10. Phillip WoodMay 8, 2024
  11. Patrick SteinhardtMay 8, 2024
  12. Justin ToblerMay 10, 2024
  13. Junio C HamanoMay 10, 2024
  14. Patrick SteinhardtMay 14, 2024
  15. docs: document upcoming breaking changesPatrick Steinhardt, May 14, 2024
  16. Karthik NayakMay 14, 2024
  17. Patrick SteinhardtMay 14, 2024
  18. Junio C HamanoMay 14, 2024
  19. Dragan SimicMay 14, 2024
  20. docs: document upcoming breaking changesPatrick Steinhardt, May 24, 2024
  21. Junio C HamanoMay 24, 2024
  22. Patrick SteinhardtMay 30, 2024
  23. 0/4 docs: document upcoming breaking changesPatrick Steinhardt, May 31, 2024
  24. 1/4 docs: introduce document to announce breaking changesPatrick Steinhardt, May 31, 2024
  25. Junio C HamanoMay 31, 2024
  26. Patrick SteinhardtJun 3, 2024
  27. Junio C HamanoJun 3, 2024
  28. Patrick SteinhardtJun 4, 2024
  29. 2/4 BreakingChanges: document upcoming change from "sha1" to "sha256"Patrick Steinhardt, May 31, 2024
  30. Junio C HamanoMay 31, 2024
  31. 3/4 BreakingChanges: document removal of graftingPatrick Steinhardt, May 31, 2024
  32. 4/4 BreakingChanges: document that we do not plan to deprecate git-checkoutPatrick Steinhardt, May 31, 2024
  33. Junio C HamanoMay 31, 2024
  34. Todd ZullingerMay 31, 2024
  35. Junio C HamanoMay 31, 2024
  36. Patrick SteinhardtMay 31, 2024
  37. 0/4 docs: document upcoming breaking changesPatrick Steinhardt, Jun 3, 2024
  38. 1/4 docs: introduce document to announce breaking changesPatrick Steinhardt, Jun 3, 2024
  39. Phillip WoodJun 3, 2024
  40. Junio C HamanoJun 3, 2024
  41. Patrick SteinhardtJun 4, 2024
  42. 2/4 BreakingChanges: document upcoming change from "sha1" to "sha256"Patrick Steinhardt, Jun 3, 2024
  43. Junio C HamanoJun 3, 2024
  44. Patrick SteinhardtJun 4, 2024
  45. Junio C HamanoJun 4, 2024
  46. 3/4 BreakingChanges: document removal of graftingPatrick Steinhardt, Jun 3, 2024
  47. Junio C HamanoJun 3, 2024
  48. 4/4 BreakingChanges: document that we do not plan to deprecate git-checkoutPatrick Steinhardt, Jun 3, 2024
  49. Junio C HamanoJun 3, 2024
  50. Patrick SteinhardtJun 4, 2024
  51. 0/4 docs: document upcoming breaking changesPatrick Steinhardt, Jun 4, 2024
  52. 1/4 docs: introduce document to announce breaking changesPatrick Steinhardt, Jun 4, 2024
  53. Junio C HamanoJun 4, 2024
  54. Patrick SteinhardtJun 5, 2024
  55. Junio C HamanoJun 5, 2024
  56. Junio C HamanoJun 5, 2024
  57. Patrick SteinhardtJun 6, 2024
  58. 2/4 BreakingChanges: document upcoming change from "sha1" to "sha256"Patrick Steinhardt, Jun 4, 2024
  59. 3/4 BreakingChanges: document removal of graftingPatrick Steinhardt, Jun 4, 2024
  60. Junio C HamanoJun 4, 2024
  61. 4/4 BreakingChanges: document that we do not plan to deprecate git-checkoutPatrick Steinhardt, Jun 4, 2024
  62. Phillip WoodJun 4, 2024
  63. Junio C HamanoJun 4, 2024
  64. Patrick SteinhardtJun 5, 2024
  65. 0/4 docs: document upcoming breaking changesPatrick Steinhardt, Jun 14, 2024
  66. 1/4 docs: introduce document to announce breaking changesPatrick Steinhardt, Jun 14, 2024
  67. Junio C HamanoJun 14, 2024
  68. 2/4 BreakingChanges: document upcoming change from "sha1" to "sha256"Patrick Steinhardt, Jun 14, 2024
  69. 3/4 BreakingChanges: document removal of graftingPatrick Steinhardt, Jun 14, 2024
  70. 4/4 BreakingChanges: document that we do not plan to deprecate git-checkoutPatrick Steinhardt, Jun 14, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.