Re: [PATCH 08/20] midx: enforce chunk alignment on reading

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 11, 2023, 14:56 UTC
Message-ID: <ZSa3m7yyf/BVNKxb@nand.local>
In-Reply-To: <20231009210523.GH3282181@coredump.intra.peff.net>

On Mon, Oct 09, 2023 at 05:05:23PM -0400, Jeff King wrote:

Show 7 quoted lines

> ---
>  chunk-format.c              |  8 +++++++-
>  chunk-format.h              |  3 ++-
>  commit-graph.c              |  2 +-
>  midx.c                      |  3 ++-
>  t/t5319-multi-pack-index.sh | 14 ++++++++++++++
>  5 files changed, 26 insertions(+), 4 deletions(-)

Very nicely written and explained. I agree that the choice you made here (to validate the alignment in the chunk-format API itself when reading the table of contents) feels more sensible and places less burden on the callers.

LGTM, let's keep reading...

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.