Re: [PATCH 01/32] doc hash-file-transition: A map file for mapping between sha1 and sha256
- From
brian m. carlson <sandals@crustytoothpaste.net>
- Date
- Sep 10, 2023, 14:24 UTC
- Message-ID
- <ZP3Rr8Ei0sG0lg0R@tapette.crustytoothpaste.net>
- In-Reply-To
- <20230908231049.2035003-1-ebiederm@xmission.com>
On 2023-09-08 at 23:10:18, Eric W. Biederman wrote:
Show 18 quoted lines
> The v3 pack index file as documented has a lot of complexity making it > difficult to implement correctly. I worked with bryan's preliminary > implementation and it took several passes to get the bugs out. > > The complexity also requires multiple table look-ups to find all of > the information that is needed to translate from one kind of oid to > another. Which can't be good for cache locality. > > Even worse coming up with a new index file version requires making > changes that have the potentialy to break anything that uses the index > of a pack file. > > Instead of continuing to deal with the chance of braking things > besides the oid mapping functionality, the additional complexity in > the file format, and worry if the performance would be reasonable I > stripped down the problem to it's fundamental complexity and came up > with a file format that is exactly about mapping one kind of oid to > another, and only supports two kinds of oids.
I think this is a fine approach, and as I'm sure you noticed from my series, it's a lot more robust than trying to implement pack v3. I'd be fine with going with this approach instead of pack v3.
-- brian m. carlson (he/him or they/them) Toronto, Ontario, CA