Re: [PATCH 2/5] strbuf: factor out strbuf_expand_step()

From: Taylor Blau <me@ttaylorr.com>
Date: Jun 19, 2023, 16:10 UTC
Message-ID: <ZJB98Q6NHbK6D1uB@nand.local>
In-Reply-To: <caf8e100-1308-cb4e-d61a-4e15ee3f47f7@web.de>

On Sat, Jun 17, 2023 at 10:41:44PM +0200, René Scharfe wrote:

Show 12 quoted lines

> diff --git a/strbuf.c b/strbuf.c
> index 08eec8f1d8..a90b597da1 100644
> --- a/strbuf.c
> +++ b/strbuf.c
> @@ -415,19 +415,24 @@ void strbuf_vaddf(struct strbuf *sb, const char *fmt, va_list ap)
>  	strbuf_setlen(sb, sb->len + len);
>  }
>
> +int strbuf_expand_step(struct strbuf *sb, const char **formatp)
> +{
> +	const char *format = *formatp;
> +	const char *percent = strchrnul(format, '%');

Can format be NULL here? Obviously formatp is never NULL since it is `&s`, but we guarded the while loop in the pre-image with `while (*s)` and I am not sure that **formatp is always non-NULL here.

Thanks, Taylor