Re: [PATCH 4/5] replace strbuf_expand() with strbuf_expand_step()

From: Jeff King <peff@peff.net>
Date: Jun 27, 2023, 20:19 UTC
Message-ID: <20230627201923.GB1358527@coredump.intra.peff.net>
In-Reply-To: <8d2223b8-ab33-be5a-20ea-ad60f6cbcc75@web.de>

On Tue, Jun 27, 2023 at 06:31:55PM +0200, René Scharfe wrote:

Show 6 quoted lines

> > It does still feel like we should be handling "%%" on behalf of the
> > callers.
> 
> I feel the same, but restrained myself from doing that, so that we
> can see all the pieces for now.  It allows us to recombine them in
> better ways than before.

Yeah, since you did the work to handle "%%" in each caller, I'm OK with proceeding and letting a later refactor shrink it back down if we choose.

-Peff