Re: [PATCH 2/5] strbuf: factor out strbuf_expand_step()

From: Jeff King <peff@peff.net>
Date: Jun 27, 2023, 08:26 UTC
Message-ID: <20230627082622.GH1226768@coredump.intra.peff.net>
In-Reply-To: <caf8e100-1308-cb4e-d61a-4e15ee3f47f7@web.de>

On Sat, Jun 17, 2023 at 10:41:44PM +0200, René Scharfe wrote:

Show 10 quoted lines

> Extract the part of strbuf_expand that finds the next placeholder into a
> new function.  It allows to build parsers without callback functions and
> the overhead imposed by them.
> 
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
>  builtin/branch.c | 13 ++-----------
>  strbuf.c         | 28 ++++++++++++++--------------
>  strbuf.h         |  8 ++++++++
>  3 files changed, 24 insertions(+), 25 deletions(-)

I was a little surprised to see the change in branch.c here (as well as the one in strbuf_addftime), since the commit message just says "extract..." and doesn't mention them.

They do serve as examples of how it can be used, so I think it's OK. But it made me wonder: is this all of the sites? Or are these just examples?

-Peff