Re: [PATCH v2 11/16] revision.h: store hidden refs in a `strvec`

From: Patrick Steinhardt <ps@pks.im>
Date: Jun 6, 2023, 07:00 UTC
Message-ID: <ZH7ZqjYqyvSOHY8u@ncase>
In-Reply-To: <f765b50a8405f1653cbc2e79b375c979c4361550.1684178576.git.me@ttaylorr.com>

On Mon, May 15, 2023 at 03:23:39PM -0400, Taylor Blau wrote:

Show 20 quoted lines

> In subsequent commits, it will be convenient to have a 'const char **'
> of hidden refs (matching `transfer.hiderefs`, `uploadpack.hideRefs`,
> etc.), instead of a `string_list`.
> 
> Convert spots throughout the tree that store the list of hidden refs
> from a `string_list` to a `strvec`.
> 
> Note that in `parse_hide_refs_config()` there is an ugly const-cast used
> to avoid an extra copy of each value before trimming any trailing slash
> characters. This could instead be written as:
> 
>     ref = xstrdup(value);
>     len = strlen(ref);
>     while (len && ref[len - 1] == '/')
>             ref[--len] = '\0';
>     strvec_push(hide_refs, ref);
>     free(ref);
> 
> but the double-copy (once when calling `xstrdup()`, and another via
> `strvec_push()`) is wasteful.

I guess the proper way to fix this would be to introduce something like a `strvec_push_nodup()` function that takes ownership. And in fact this helper exists already, but it's declared as static. So we could get around the ugly cast with a simple change to expose the helper function.

Patrick