Re: [PATCH 04/15] ref-filter: add ref_filter_clear()

From: Patrick Steinhardt <ps@pks.im>
Date: May 9, 2023, 15:14 UTC
Message-ID: <ZFpjaUaDl7eUCh8N@ncase>
In-Reply-To: <c804ba3620476713bd0535a315876378149ad7dd.1683581621.git.me@ttaylorr.com>

On Mon, May 08, 2023 at 05:59:52PM -0400, Taylor Blau wrote:

Show 5 quoted lines

> From: Jeff King <peff@peff.net>
> 
> We did not bother to clean up at all in branch/tag, and for-each-ref
> only hit a few elements. So this is probably cleaning up leaks, but I
> didn't check yet.

Nit: it sounds like there still is the intent to check whether this does
fix leaks. How about updating the commit message to either not mention
the intent or perform the check?

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.