Re: [PATCH 08/15] refs/packed-backend.c: refactor `find_reference_location()`

From: Taylor Blau <me@ttaylorr.com>
Date: May 9, 2023, 20:29 UTC
Message-ID: <ZFqtOPO5MMrG60S3@nand.local>
In-Reply-To: <xmqq5y924bt2.fsf@gitster.g>

On Mon, May 08, 2023 at 04:56:41PM -0700, Junio C Hamano wrote:

> So, yes I can agree that this does not introduce any new bug, it is
> a mysterious no-op, and why we want to pass different values in "start"
> in future steps in order to achieve what is not explained and leaves
> the readers frustrated.

Re-reading this patch again with your review in mind, I agree that the split is poorly placed.

I modified this patch to just extract the core routine behind a helper function and avoided adding the "start" parameter here.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.