Re: [PATCH v2 7/8] fetch: introduce new `--output-format` option

From: Patrick Steinhardt <ps@pks.im>
Date: May 3, 2023, 09:12 UTC
Message-ID: <ZFIll22dBQvSm2nz@ncase>
In-Reply-To: <kl6l8reb3br4.fsf@chooglen-macbookpro.roam.corp.google.com>

On Fri, Apr 28, 2023 at 03:03:43PM -0700, Glen Choo wrote:

Show 13 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> 
> > I wonder if
> >
> > 	static const char *const display_format[] = {
> > 		[DISPLAY_FORMAT_UNKNOWN] = NULL,
> > 		[DISPLAY_FORMAT_FULL] = "full",
> > 		[DISPLAY_FORMAT_COMPACT] = "compact",
> > 	};
> >
> > would be easier to maintain?
> 
> It's easier to read, so I'd think so.

Yeah, I'll adopt this approach in v3.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.