Re: [PATCH 7/8] fetch: introduce new `--output-format` option

From: Patrick Steinhardt <ps@pks.im>
Date: Apr 27, 2023, 10:58 UTC
Message-ID: <ZEpVT-QjzYrmqgw-@ncase>
In-Reply-To: <kl6l1qk6o2jm.fsf@chooglen-macbookpro.roam.corp.google.com>

On Wed, Apr 26, 2023 at 12:40:13PM -0700, Glen Choo wrote:

Show 17 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
> 
> > @@ -2101,6 +2116,8 @@ int cmd_fetch(int argc, const char **argv, const char *prefix)
> >  			    PARSE_OPT_OPTARG, option_fetch_parse_recurse_submodules),
> >  		OPT_BOOL(0, "dry-run", &dry_run,
> >  			 N_("dry run")),
> > +		OPT_CALLBACK(0, "output-format", &display_format, N_("format"), N_("output format"),
> > +			     opt_parse_output_format),
> >  		OPT_BOOL(0, "write-fetch-head", &write_fetch_head,
> >  			 N_("write fetched references to the FETCH_HEAD file")),
> >  		OPT_BOOL('k', "keep", &keep, N_("keep downloaded pack")),
> 
> This change is good enough for fetching from a single remote, but if we
> want to support "--all", we'd also need to propagate the CLI flag to the
> child "fetch" processes. (The config option wouldn't have this bug
> because the child processes would parse config and get the correct
> value.)

Oh, right, good catch. Will fix, thanks!

Patrick