Re: [PATCH v2 8/8] fetch: introduce machine-parseable "porcelain" output format

From: Jacob Keller <jacob.e.keller@intel.com>
Date: Apr 27, 2023, 19:52 UTC
Message-ID: <2876e9b5-b9a6-713d-8c0c-0561e1c6d6da@intel.com>
In-Reply-To: <d7c1bc1a80406ad320c2de684e0c97ba14827c7a.1682593865.git.ps@pks.im>

On 4/27/2023 4:13 AM, Patrick Steinhardt wrote:

Show 8 quoted lines

> A notable ommission here is that the output format does not include the
> remote from which a reference was fetched, which might be important
> information especially in the context of multi-remote fetches. But as
> such a format would require us to print the remote for every single
> reference update due to parallelizable fetches it feels wasteful for the
> most likely usecase, which is when fetching from a single remote. If
> usecases come up for this in the future though it is easy enough to add
> a new "porcelain-v2" format that adds this information.

Thanks for clarifying this. I think generally its ok to leave out since you can often infer what remote a ref came from (either because of refs/remotes, or because of how you configured your refspecs for fetching).

We do have the option to extend this in the future if needed, so I think that's ok. In that case if we wanted an even more verbose output I'd probably argue for something more structured like adding it as part of a JSON output.

Thanks, Jake