Re: [PATCH v3 14/20] t/lib-gpg: refactor `sanitize_pgp()` to not depend on Perl

From: Patrick Steinhardt <ps@pks.im>
Date: Apr 2, 2025, 07:16 UTC
Message-ID: <Z-zkSpKsvEYWw4Pr@pks.im>
In-Reply-To: <c909b89f-7432-2d35-cfdb-0de9f94a7281@gmx.de>

On Tue, Apr 01, 2025 at 08:56:41PM +0200, Johannes Schindelin wrote:

Show 14 quoted lines

> 
> Hi Patrick,
> 
> On Thu, 27 Mar 2025, Patrick Steinhardt wrote:
> 
> > The `sanitize_pgp()` test helper uses Perl to strip PGP signatures from
> > stdin. Refactor it to instead use awk(1) so that we drop the
> > PERL_TEST_HELPERS prerequisite in users of this library.
> 
> It's my fault that this commit message is no longer correct because I
> talked you into using `sed` instead...
> 
> Sorry,
> Johannes

No need to be sorry, should've catched that myself :) Thanks for the suggestion in the first place, it made the new logic quite a bit easier to read!

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.