Re: [PATCH 01/20] t: skip chain lint when PERL_PATH is unset

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 20, 2025, 18:36 UTC
Message-ID: <CAPig+cQ0ny060F1fdnCqZ=kALgMe5msxvKE-Dq+ECKxwwgfRFQ@mail.gmail.com>
In-Reply-To: <20250320-b4-pks-t-perlless-v1-1-b1eefe27ac55@pks.im>

On Thu, Mar 20, 2025 at 5:35 AM Patrick Steinhardt <ps@pks.im> wrote:

> Our chainlint scripts verify that test files have proper '&&' chains.

It's just a single script, so: s/scripts verify/script verifies/

> These scripts are written in Perl and are executed for every test file

s/These scripts/This script/ s/are/is/g

Show 13 quoted lines

> before executing the test logic itself.
>
> In subsequent commits we're about to refactor our test suite so that
> Perl becomes an optional dependency, only. And while it is already
> possible to disable this linter, developers that don't have Perl
> available at all would always have to disable the linter manually, which
> is rather cumbersome.
>
> Disable the chain linter automatically in case PERL_PATH isn't set to
> make this a bit less annoying. Bail out with an error in case the
> developer has asked explicitly for the chain linter.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>

Not worth a reroll, of course.