Re: [PATCH 13/20] t: refactor tests depending on Perl for textconv scripts

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 20, 2025, 19:37 UTC
Message-ID: <CAPig+cQdoZwY3u-xr49Jb8aaQmE69p4i4RUdy=cRv-V7VoWENg@mail.gmail.com>
In-Reply-To: <20250320-b4-pks-t-perlless-v1-13-b1eefe27ac55@pks.im>

On Thu, Mar 20, 2025 at 5:37 AM Patrick Steinhardt <ps@pks.im> wrote:

Show 23 quoted lines

> We have a couple of tests that depend on Perl for textconv scripts.
> Refactor these tests to instead be implemented via shell utilities so
> that we can drop a couple of PERL_TEST_HELPERS prerequisites.
>
> Note that not all of the conversions are a one-to-one equivalent to the
> previous textconv scripts. But that's not really needed in the first
> place: we only care that the textconv script does something, and that
> can be verified trivially without having a full-blown invocation of
> hexdump. So at times, the implementation of the textconv scripts is
> reduced to their bare minimum.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
> -test_expect_success PERL_TEST_HELPERS 'rewrite diff respects textconv' '
> +test_expect_success 'rewrite diff respects textconv' '
>         git diff -B >diff &&
> -       grep "dissimilarity index" diff &&
> -       grep "^-61" diff &&
> -       grep "^-0" diff
> +       test_grep "dissimilarity index" diff &&
> +       test_grep "^-3d 0a 00" diff &&
> +       test_grep "^+3d 0a 01" diff
>  '

This change seems unrelated to the stated purpose (`textconv`) of this patch(?).