Re: [PATCH v2 0/2] avoid pipes with Git on LHS

From: Taylor Blau <me@ttaylorr.com>
Date: Feb 23, 2022, 18:01 UTC
Message-ID: <YhZ2Zpl3XGkTKxuI@nand.local>
In-Reply-To: <CAJyCBOTiWxAgkZPB6M5jPw=t=32zrnNH5tfnOc9Kdj9mKayrSA@mail.gmail.com>

On Wed, Feb 23, 2022 at 09:19:23PM +0800, Shaoxuan Yuan wrote:

Show 15 quoted lines

> On Wed, Feb 23, 2022 at 8:42 PM Shubham Mishra <shivam828787@gmail.com> wrote:
> >
> > Hi,
>
> Hi,
>
> > I am using mails for code review for the first time, I have some
> > doubts, Can someone please clarify them? -
> > 1. It looks like the cover letter (Including "Range-diff" section) is
> > only for context sharing with reviewers, nothing from it gets merged
> > to the "seek" or any other branch.
>
> The cover letter stands for an introduction/summary to your patches.
> You can also put helpful context in it for better understanding. According
> to my knowledge, it will not be in the commit messages.

Right; the cover letter (along with any notes below the '---' in your patches do not make it into the commit history).

The range-diff you posted is empty and doesn't look quite right to me... when I applied both versions of your patches locally and generated a range-diff myself, I got the expected (non-empty) results.

I'm not sure exactly how you're generating the range-diff locally, but you may want to make sure that you're picking the previous version correctly (and not doing something like `git range-diff master HEAD HEAD`, which is what I suspect may have happened).

Show 8 quoted lines

> > 2. I wanted to know how the merging process takes place. Once the
> > patch is accepted, do we merge all previous versions of it one after
> > another or every patch is independent so we have to just merge the
> > last accepted patch?
>
> Not so sure about this question. My two cents: generally the most agreed-upon
> patch will be merged, but the exact merging process could vary based
> on the circumstances. Probably Junio can have a better answer to this.

Emily Shaffer did some great work a couple of years ago on a "My First Contribution" tutorial, which you can find in Documentation/MyFirstContribution.txt.

The section "My Patch Got Emailed - Now What?" provides a good overview of the review and queuing process.

Thanks, Taylor