Re: [PATCH 1/2] t0001: remove pipes

From: Christian Couder <christian.couder@gmail.com>
Date: Feb 24, 2022, 03:28 UTC
Message-ID: <CAP8UFD0miSWhksE8aWUY6awhf4sCNSO1mfPni2EEi94fzFnyoA@mail.gmail.com>
In-Reply-To: <xmqqsfs9thq7.fsf@gitster.g>

On Wed, Feb 23, 2022 at 10:07 PM Junio C Hamano <gitster@pobox.com> wrote:

Show 17 quoted lines

>
> Christian Couder <christian.couder@gmail.com> writes:
>
> > Only the exit code of the command before the pipe is ignored.
> >
> > Also it's ok to use pipes if the command before the pipe is not `git`.
> > We trust regular commands to just work and we test only `git`.
>
> Both very good points.  So ...
>
> >> -               find .git/worktrees -print | sort >expected &&
> >> +               find .git/worktrees -print >tmp && sort tmp >expected &&
> >
> > Please put the `find` and `sort` commands on 2 different lines when
> > they are separated with &&.
>
> We do not want to split this pipeline into two commands.

Yeah, right.