Re: [PATCH 0/2] microproject: avoid using pipes in test
- From
Christian Couder <christian.couder@gmail.com>
- Date
- Feb 24, 2022, 09:29 UTC
- Message-ID
- <CAP8UFD1dfXHYudpT=0e_2DZdmZMKyqKO13EbPozwpZkEYewxNw@mail.gmail.com>
- In-Reply-To
- <CAC316V5x54Ah566haa5wZ8zE=gkhYtziC+FVjXoBXn7xY_-WsQ@mail.gmail.com>
On Thu, Feb 24, 2022 at 6:22 AM Shubham Mishra <shivam828787@gmail.com> wrote:
Show 9 quoted lines
> > > This is my first contribution that's why I am keeping diff short with an intention to understand the process instead of making impactful change in first attempt. Later, I will send more patches to fix the issue for other files. > > > > Please read the "Only ONE quality focused microproject per student" > > section of the above mentioned page. > > here I mean in next patches, I will be fixing the same "Git on LHS of > pipe" for other tests. I think that will be considered as the same > microproject and I am still eligible to fix the same thing for other > files?
In the "Only ONE quality focused microproject per student" section, there is:
=> This means that for a microproject that consist in refactoring or rewriting a small amount of code, your patch should change only ONE file, or perhaps 2 files if they are closely related, like “foo.c” and “foo.h”.
So, no, we really prefer you to focus on 1 file (or 2 files when they are strongly related) and then move on to your application or regular patches, reviews, discussions, etc.