Re: [PATCH v2 1/2] t0001: avoid pipes with Git on LHS

From: Taylor Blau <me@ttaylorr.com>
Date: Feb 23, 2022, 17:53 UTC
Message-ID: <YhZ0qOwtY1vUVTiN@nand.local>
In-Reply-To: <20220223115347.3083-2-shivam828787@gmail.com>

On Wed, Feb 23, 2022 at 05:23:46PM +0530, Shubham Mishra wrote:

> Pipes ignore error codes of LHS command and thu`s we should not use
> them with Git in tests. As an alternative, use a 'tmp' file to write
> the Git output so we can test the exit code.

This patch does preserve the existing behavior. But I'm hesitant to recommend that we apply this patch, since our test suite assumes that commands like find will work, and so we aren't concerned about squashing any potential error codes when it's on the left-hand side of the pipe, since we assume that it won't fail in general.

(That's notably different from the second patch in this series, where the thing on the left-hand side of the pipe is a git invocation. In that case, we really _do_ want to avoid having it on the left-hand side of the pipe, because we don't have the same error-free expectation there, and want to know when it fails).

I think that Ævar gave a nice summary of the above in [1]

Thanks, Taylor

[1]: https://lore.kernel.org/git/220222.86pmnf6ket.gmgdl@evledraar.gmail.com/