Re: ab/run-command (was: What's cooking in git.git (Dec 2021, #04; Wed, 15))

From: Jeff King <peff@peff.net>
Date: Dec 16, 2021, 15:31 UTC
Message-ID: <Ybtb6Shdj56ACdub@coredump.intra.peff.net>
In-Reply-To: <211216.868rwkbv1b.gmgdl@evledraar.gmail.com>

On Thu, Dec 16, 2021 at 12:51:55PM +0100, Ævar Arnfjörð Bjarmason wrote:

Show 5 quoted lines

> Or maybe you're not interested in either case, which is also fine. It's
> really not needed for anything other than to resolve the minor oddity
> that we have two "struct strvec"'s, "args" and "env_array". It's just a
> bit odd to have one with "_array" in the name, which is only because the
> now-removed "env" was taken at the time.

Yeah, FWIW I absolutely hated "env_array" when I added it, but didn't want to do the transition all at once, so needed another name. So I would be happy to see it become "env" now. ;)

Turning "args" into "argv" is less important, just because the name is less long and ugly. And since "argv" is both the concept of the arg list and also the well-known main() parameter with a different type, arguably using it for a type besides "const char **" could be confusing (though I don't find it so personally).

-Peff