git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] wrapper: remove xunsetenv()

From
Jeff King <peff@peff.net>
Date
Oct 29, 2021, 22:00 UTC
Message-ID
<YXxvGfelee1pURQ7@coredump.intra.peff.net>
In-Reply-To
<xmqqbl37ijc7.fsf@gitster.g>
On Fri, Oct 29, 2021 at 02:58:48PM -0700, Junio C Hamano wrote:
Show 15 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > However, according to the unsetenv() manpage:
> >
> >   Prior to glibc 2.2.2, unsetenv() was prototyped as returning void;
> >   more recent glibc versions follow the POSIX.1-compliant prototype
> >   shown in the SYNOPSIS.
> >
> > So it is POSIX to return an int, but that gives us at least one platform
> > where unsetenv() returns void (or used to). glibc 2.2.2 is 2001-era, so
> > that may be old enough that we don't care. But it makes me wonder if
> > other older or obscure platforms will run into this.
> 
> Ahh, OK.  Well, we will hear from them soon enough.  It is not like
> this is anything urgent.

Yeah, I am OK proceeding along those lines, and seeing if anybody screams (though perhaps dropping xunsetenv() for -rc0 makes sense in the interim).

-Peff
Previous: Junio C HamanoNext: Junio C Hamano
Message 8 of 17 in “wrapper: remove xunsetenv()”
  1. wrapper: remove xunsetenv()Carlo Marcelo Arenas Belón, Oct 29, 2021
  2. Jeff KingOct 29, 2021
  3. rsbecker@nexbridge.comOct 29, 2021
  4. Carlo ArenasOct 29, 2021
  5. Junio C HamanoOct 29, 2021
  6. Jeff KingOct 29, 2021
  7. Junio C HamanoOct 29, 2021
  8. Jeff KingOct 29, 2021
  9. Junio C HamanoOct 29, 2021
  10. Jeff KingOct 29, 2021
  11. rsbecker@nexbridge.comOct 29, 2021
  12. Junio C HamanoOct 29, 2021
  13. rsbecker@nexbridge.comOct 30, 2021
  14. rsbecker@nexbridge.comOct 29, 2021
  15. Carlo ArenasOct 29, 2021
  16. rsbecker@nexbridge.comOct 29, 2021
  17. Junio C HamanoOct 29, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.