git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] wrapper: remove xunsetenv()

From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
Date
Oct 29, 2021, 21:27 UTC
Message-ID
<20211029212705.31721-1-carenas@gmail.com>
In-Reply-To
<013a01d7cd092d91cb088b5610nexbridge.com>

Platforms that are using the git compatibility layer for unsetenv use void as a return value for unsetenv(), so any function that checks for a return value will fail to build.

Remove the unused wrapper function.
Reported-by: Randall S. Becker <rsbecker@nexbridge.com>
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
 git-compat-util.h | 1 -
 wrapper.c         | 6 ------
 2 files changed, 7 deletions(-)
diff --git a/git-compat-util.h b/git-compat-util.h
index 141bb86351..d70ce14286 100644
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@ -879,7 +879,6 @@ char *xstrndup(const char *str, size_t len);
 void *xrealloc(void *ptr, size_t size);
 void *xcalloc(size_t nmemb, size_t size);
 void xsetenv(const char *name, const char *value, int overwrite);
-void xunsetenv(const char *name);
 void *xmmap(void *start, size_t length, int prot, int flags, int fd, off_t offset);
 const char *mmap_os_err(void);
 void *xmmap_gently(void *start, size_t length, int prot, int flags, int fd, off_t offset);
diff --git a/wrapper.c b/wrapper.c
index 1460d4e27b..36e12119d7 100644
--- a/wrapper.c
+++ b/wrapper.c
@@ -151,12 +151,6 @@ void xsetenv(const char *name, const char *value, int overwrite)
 		die_errno(_("could not setenv '%s'"), name ? name : "(null)");
 }
 
-void xunsetenv(const char *name)
-{
-	if (!unsetenv(name))
-		die_errno(_("could not unsetenv '%s'"), name ? name : "(null)");
-}
-
 /*
  * Limit size of IO chunks, because huge chunks only cause pain.  OS X
  * 64-bit is buggy, returning EINVAL if len >= INT_MAX; and even in
-- 
2.33.1.1200.g715dc68e71
Next: Jeff King
Message 1 of 17 in “wrapper: remove xunsetenv()”
  1. wrapper: remove xunsetenv()Carlo Marcelo Arenas Belón, Oct 29, 2021
  2. Jeff KingOct 29, 2021
  3. rsbecker@nexbridge.comOct 29, 2021
  4. Carlo ArenasOct 29, 2021
  5. Junio C HamanoOct 29, 2021
  6. Jeff KingOct 29, 2021
  7. Junio C HamanoOct 29, 2021
  8. Jeff KingOct 29, 2021
  9. Junio C HamanoOct 29, 2021
  10. Jeff KingOct 29, 2021
  11. rsbecker@nexbridge.comOct 29, 2021
  12. Junio C HamanoOct 29, 2021
  13. rsbecker@nexbridge.comOct 30, 2021
  14. rsbecker@nexbridge.comOct 29, 2021
  15. Carlo ArenasOct 29, 2021
  16. rsbecker@nexbridge.comOct 29, 2021
  17. Junio C HamanoOct 29, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.