RE: [PATCH] wrapper: remove xunsetenv()

From: rsbecker@nexbridge.com <rsbecker@nexbridge.com>
Date: Oct 29, 2021, 21:43 UTC
Message-ID: <014901d7cd0e$042a3470$0c7e9d50$@nexbridge.com>
In-Reply-To: <YXxpjLhiguq4HY6g@coredump.intra.peff.net>

On October 29, 2021 5:37 PM, Jeff King wrote:

Show 17 quoted lines

> On Fri, Oct 29, 2021 at 02:27:05PM -0700, Carlo Marcelo Arenas Belón wrote:
> 
> > Platforms that are using the git compatibility layer for unsetenv use
> > void as a return value for unsetenv(), so any function that checks for
> > a return value will fail to build.
> 
> Good catch.
> 
> > Remove the unused wrapper function.
> 
> I don't mind removing this if nobody is using it, but doesn't your first paragraph
> argue that our definition of gitunsetenv() is just wrong?
> I.e., it should return an int, even if it is always "0"?
> 
> Or is it a portability question? I.e., are there platforms where
> unsetenv() also returns void, in which case we must make sure nobody ever
> looks at its return value (and xunsetenv() is therefore a wrong direction)?

At least on NonStop x86, it is

       int unsetenv(const char *name);

--Randall