RE: [PATCH] wrapper: remove xunsetenv()

From: rsbecker@nexbridge.com <rsbecker@nexbridge.com>
Date: Oct 30, 2021, 00:13 UTC
Message-ID: <015d01d7cd22$fa6c6970$ef453c50$@nexbridge.com>
In-Reply-To: <xmqq35ojihx7.fsf@gitster.g>

On October 29, 2021 6:29 PM, Junio C Hamano wrote:

Show 22 quoted lines

> <rsbecker@nexbridge.com> writes:
> 
> > On October 29, 2021 5:59 PM, Junio C Hamano wrote:
> >> Jeff King <peff@peff.net> writes:
> >>
> >> > However, according to the unsetenv() manpage:
> >> >
> >> >   Prior to glibc 2.2.2, unsetenv() was prototyped as returning void;
> >> >   more recent glibc versions follow the POSIX.1-compliant prototype
> >> >   shown in the SYNOPSIS.
> >> >
> >> > So it is POSIX to return an int, but that gives us at least one
> >> > platform where unsetenv() returns void (or used to). glibc 2.2.2 is
> >> > 2001-era, so that may be old enough that we don't care. But it
> >> > makes me wonder if other older or obscure platforms will run into this.
> >>
> >> Ahh, OK.  Well, we will hear from them soon enough.  It is not like
> >> this is anything urgent.
> >
> > Well... maybe for some of us 😉
> 
> Heh, but we all know you are capable of locally patching ;-).

Our CI/CD uses Jenkins and depends directly on the git repo, like normal people 😉