Re: [PATCH 0/3] packfile: use oidset for bad objects

From: Jeff King <peff@peff.net>
Date: Sep 11, 2021, 14:27 UTC
Message-ID: <YTy81+Xq5G1fRxU8@coredump.intra.peff.net>
In-Reply-To: <4a702bfe-afd0-669a-c893-0262289c24b8@web.de>

On Sat, Sep 11, 2021 at 09:50:36AM +0200, René Scharfe wrote:

> Replace the custom hash array for remembering corrupt pack entries with
> an oidset.  This shortens and simplifies the code.

Thanks, these were a pleasure to read.

I noticed one possible small performance change in the third patch. It should be easy to remedy if we want (but I could also believe that it doesn't matter either way, if you care to argue that :) ).

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.