Re: [PATCH v2 0/5] packfile: use oidset for bad objects

From: Taylor Blau <me@ttaylorr.com>
Date: Sep 12, 2021, 01:51 UTC
Message-ID: <YT1dCAuCE7xIIIk/@nand.local>
In-Reply-To: <9cdf54db-132e-d771-e177-6673f7ad02bf@gmail.com>

On Sat, Sep 11, 2021 at 07:59:40PM -0400, Derrick Stolee wrote:

> I initially hesitated to support the drop of
> nth_midxed_pack_entry(), since it was designed with things
> like midx bitmaps in mind (specifically, to also support
> lex-order-to-stable-order conversions).

I didn't know that nth_midxed_pack_entry was designed with either purpose in mind, since it predates midx bitmaps by quite a bit.

> However, it seems that the midx bitmap series by Taylor is succeeding
> without needing such a translation.

Right, it looks like that function is only called by fill_midx_entry() where it was inlined.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.