Re: [PATCH v2 0/5] packfile: use oidset for bad objects

From: Taylor Blau <me@ttaylorr.com>
Date: Sep 12, 2021, 02:29 UTC
Message-ID: <YT1l75uQ50e2IaXM@nand.local>
In-Reply-To: <YT1dCAuCE7xIIIk/@nand.local>

On Sat, Sep 11, 2021 at 09:51:04PM -0400, Taylor Blau wrote:

Show 8 quoted lines

> On Sat, Sep 11, 2021 at 07:59:40PM -0400, Derrick Stolee wrote:
> > I initially hesitated to support the drop of
> > nth_midxed_pack_entry(), since it was designed with things
> > like midx bitmaps in mind (specifically, to also support
> > lex-order-to-stable-order conversions).
>
> I didn't know that nth_midxed_pack_entry was designed with either
> purpose in mind, since it predates midx bitmaps by quite a bit.

Thinking on it more, I can imagine that you wrote this function aspirationally envisioning something like MIDX bitmaps. And since you and I discussed the design together quite a bit, I imagine that that's the case ;-).

But I agree that after reading this series again, that the inline-ing suggested makes sense (and doesn't conflict with any series I have in flight which don't add any new callers).

Thanks, Taylor