Re: [PATCH v2 0/5] packfile: use oidset for bad objects

From: Jeff King <peff@peff.net>
Date: Sep 11, 2021, 21:22 UTC
Message-ID: <YT0eBC16DLkd80Ak@coredump.intra.peff.net>
In-Reply-To: <e50c1465-59de-7fe1-de01-800404c7640e@web.de>

On Sat, Sep 11, 2021 at 10:31:52PM +0200, René Scharfe wrote:

Show 7 quoted lines

> Replace the custom hash array for remembering corrupt pack entries with
> an oidset.  This shortens and simplifies the code.
> 
> Changes since v1:
> - inline oidset_size()
> - inline nth_midxed_pack_entry() early
> - use oidset_size() to avoid a function call if no bad objects exist

Thanks, these all look fine to me. I raised a question elsewhere in the thread about inlining oidset_contains(), but I think that can be considered separately (and is less clear-cut; we might win by saving a function call, but we might lose due to larger code size).

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.