Re: [PATCH 9/9] docs: document symlink restrictions for dot-files

From: Jeff King <peff@peff.net>
Date: May 3, 2021, 20:33 UTC
Message-ID: <YJBd/9rSkLQ68ECy@coredump.intra.peff.net>
In-Reply-To: <CAPig+cTmL3R=xB_zjFLZkZ3X4pOABj-OvLsbDsW91WKCv-bjHA@mail.gmail.com>

On Sat, May 01, 2021 at 03:16:09PM -0400, Eric Sunshine wrote:

Show 14 quoted lines

> Just a really microscopic nit... feel free to ignore...
> 
> > diff --git a/Documentation/gitattributes.txt b/Documentation/gitattributes.txt
> > @@ -1247,6 +1247,13 @@ to:
> > +NOTES
> > +-----
> > +
> > +Note that Git does not follow symbolic links when accessing a
> > +`.gitattributes` file in the working tree. This keeps behavior
> > +consistent when the file is accessed from the index or a tree versus
> > +from the filesystem.
> 
> We're in the "NOTES" section, so it feels redundant to begin the
> sentence with "Note that".

Thanks. I think it's a good suggestion. I agree it's pretty minor, but I'm going to re-roll anyway to drop the test_i18ngrep, so I'll reword this, too.

-Peff