Re: [PATCH 5/9] t7450: test verify_path() handling of gitmodules
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- May 1, 2021, 18:55 UTC
- Message-ID
- <CAPig+cSxB89mJcjaoLMLEgqdqi9SSP5+R9qjbVydvA-kVq-2+g@mail.gmail.com>
- In-Reply-To
- <YI124aZ1dbY5O67J@coredump.intra.peff.net>
On Sat, May 1, 2021 at 11:42 AM Jeff King <peff@peff.net> wrote:
Show 26 quoted lines
> Commit 10ecfa7649 (verify_path: disallow symlinks in .gitmodules,
> 2018-05-04) made it impossible to load a symlink .gitmodules file into
> the index. However, there are no tests of this behavior. Let's make sure
> this case is covered. We can easily reuse the test setup created by
> the matching b7b1fca175 (fsck: complain when .gitmodules is a symlink,
> 2018-05-04).
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> diff --git a/t/t7450-bad-git-dotfiles.sh b/t/t7450-bad-git-dotfiles.sh
> @@ -139,7 +139,7 @@ test_expect_success 'index-pack --strict works for non-repo pack' '
> -test_expect_success 'fsck detects symlinked .gitmodules file' '
> +test_expect_success 'set up repo with symlinked .gitmodules file' '
> git init symlink &&
> (
> cd symlink &&
> @@ -155,8 +155,14 @@ test_expect_success 'fsck detects symlinked .gitmodules file' '
> {
> printf "100644 blob $content\t$tricky\n" &&
> printf "120000 blob $target\t.gitmodules\n"
> - } >bad-tree &&
> - tree=$(git mktree <bad-tree) &&
> + } >bad-tree
> + ) &&
> + tree=$(git -C symlink mktree <symlink/bad-tree)
> +'`tree` is an unusually generic name for this now-global variable. One can easily imagine it being re-used by some unrelated test arbitrarily inserted into this script, thus potentially breaking the following tests which depend upon it. I wonder if a name such as `BAD_TREE` would be more appropriate.