Re: [PATCH v2 0/2] Asciidoctor native manpage builds

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: May 14, 2021, 20:00 UTC
Message-ID: <YJ7W4YrboXQhMh/B@camp.crustytoothpaste.net>
In-Reply-To: <609eca5a42be2_43127208f2@natae.notmuch>

On 2021-05-14 at 19:07:06, Felipe Contreras wrote:

Show 12 quoted lines

> brian m. carlson wrote:
> >     @@ Documentation/asciidoctor-extensions.rb: module Git
> >               elsif parent.document.basebackend? 'html'
> >                 %(<a href="#{prefix}#{target}.html">#{target}(#{attrs[1]})</a>)
> >      +        elsif parent.document.basebackend? 'manpage'
> >     -+          %(\\fB#{target}\\fP\\fR(#{attrs[1]})\\fP)
> >     ++          %(\e\\fB#{target}\e\\fP\e\\fR(#{attrs[1]})\e\\fP)
> >               elsif parent.document.basebackend? 'docbook'
> >                 "<citerefentry>\n" \
> >                   "<refentrytitle>#{target}</refentrytitle>" \
> 
> Huh? Didn't you say \e was not needed?

Yes, but I believe in that case my build was broken and I was incorrect.

> You are doing basically the same thing thing my patches now, except in a
> more convoluted way.

The way your patches do it, if someone adds a line like this:

  _abc linkgit:git-update-index[1] def_

the latter part (def) is not italicized. In my version, it is, which is the correct behavior.

-- 
brian m. carlson (he/him or they/them)
Houston, Texas, US