Re: [PATCH 1/2] doc: add an option to have Asciidoctor build man pages directly

From: Martin Ågren <martin.agren@gmail.com>
Date: May 13, 2021, 17:30 UTC
Message-ID: <CAN0heSqxFdiwF=--DaBFMqmvjMDY__hvs+u0vfc=GG1jcqZwoQ@mail.gmail.com>
In-Reply-To: <YJt81neO7zsGz2ah@coredump.intra.peff.net>

On Wed, 12 May 2021 at 08:59, Jeff King <peff@peff.net> wrote:

Show 17 quoted lines

> We seem to have a problem with some escape codes. E.g.:
>
>   -           of nothing). The other file, git-add--interactive.perl, has 403
>   -           lines added and 35 lines deleted if you commit what is in the
>   -           index, but working tree file has further modifications (one
>   +           of nothing). The other file, git-add&#x2d;&#x2d;interactive.perl,
>   +           has 403 lines added and 35 lines deleted if you commit what is in
>   +           the index, but working tree file has further modifications (one
>
> and:
>
>   -           Added content is represented by lines beginning with "+". You can
>   -           prevent staging any addition lines by deleting them.
>   +           Added content is represented by lines beginning with "&#43;". You
>   +           can prevent staging any addition lines by deleting them.
>
> which is a pretty bad regression.

ASCIIDOC_EXTRA += -aplus='+' ASCIIDOC_EXTRA += -alitdd='\--'

seems to have done the trick for me at one point, but Todd had some concerns [1] that it interacted badly with the html build, so we might need to use a less aggressive choice of makefile variable to only affect the direct manpage generation.

[1] https://lore.kernel.org/git/20190323192756.GK4047@pobox.com/

Martin